Code Smell 257 - Simplifying Property Names By Removing Prefixes

9 Jul 2024

Avoid Using the Prefix "Collection" on Properties

TL;DR: Drop "collection" prefix for clarity.

Problems

Redundant Naming
Verbose Code
Reduced Readability
Refactoring Challenges
Coupled to implementation

Solutions

Use Simple Names
Remove 'collection' from the name
Use plural names without the word 'collection.'

Context

When you prefix properties with terms like "collection," you introduce redundancy and verbosity into your code.

This makes your code harder to read and maintain and adds unnecessary complexity.

Coupling the name to a collection implementation prevents you from introducing a proxy or middle object to manage the relation.

Sample Code

Wrong

struct Task {
    collection_of_subtasks: Vec<Subtask>,
    subtasks_collection: Vec<Subtask>,
}

impl Task {
    fn add_subtask(&mut self, subtask: Subtask) {
        self.collection_of_subtasks.push(subtask);
        self.subtasks_collection.push(subtask);
    }
}

Right

struct Task {
    subtasks: Vec<Subtask>,
}

impl Task {
    fn add_subtask(&mut self, subtask: Subtask) {
        self.subtasks.push(subtask);
    }
}